Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm-worker: use run ctx instead global ctx to fix double write #7661

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Nov 21, 2022

What problem does this PR solve?

Issue Number: close #7658

What is changed and how it works?

  • use runCtx running job
  • use kaCtx for keepalive

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 21, 2022
@GMHDBJD GMHDBJD added type/bugfix This PR fixes a bug. area/dm Issues or PRs related to DM. labels Nov 21, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #7661 (a7646b1) into master (01e0f31) will increase coverage by 0.0961%.
The diff coverage is 78.2608%.

Additional details and impacted files
Flag Coverage Δ
cdc 66.2842% <ø> (+0.0348%) ⬆️
dm 52.1414% <82.3529%> (-0.0002%) ⬇️
engine 64.4315% <66.6666%> (+0.6482%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7661        +/-   ##
================================================
+ Coverage   59.8250%   59.9212%   +0.0961%     
================================================
  Files           812        812                
  Lines         93078      92927       -151     
================================================
- Hits          55684      55683         -1     
+ Misses        32541      32393       -148     
+ Partials       4853       4851         -2     

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 21, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 24, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a7646b1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 24, 2022

/verify-ci

@ti-chi-bot ti-chi-bot merged commit 30225db into pingcap:master Nov 24, 2022
@fubinzh
Copy link

fubinzh commented Nov 30, 2022

/label needs-cherry-pick-release-6.1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7745.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM data inconsistency after dm worker down
6 participants