Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema (ticdc): support exchange partition (#7118) #7161

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7118

What problem does this PR solve?

Issue Number: close #6322 #639

What is changed and how it works?

It is well commented in the code, plz take a look at it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Make CDC support exchange partition ddl.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.3 This PR is cherry-picked to release-6.3 from a source PR. labels Sep 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-6.3@e3bedc4). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ
cdc 67.1241% <0.0000%> (?)
dm 51.8686% <0.0000%> (?)
engine 62.9010% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.3      #7161   +/-   ##
================================================
  Coverage               ?   59.8676%           
================================================
  Files                  ?        791           
  Lines                  ?      90954           
  Branches               ?          0           
================================================
  Hits                   ?      54452           
  Misses                 ?      31731           
  Partials               ?       4771           

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 21, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5f477b1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@asddongmen
Copy link
Contributor

/run-dm-integration-test
/run-kafka-integration-tests

@asddongmen
Copy link
Contributor

/run-kafka-integration-tests

1 similar comment
@asddongmen
Copy link
Contributor

/run-kafka-integration-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor

/run-kafka-integration-tests
/run-unit-tests

@asddongmen
Copy link
Contributor

/run-all-tests

@nongfushanquan
Copy link
Contributor

/run-verify
/run-dm-compatibility-test

@ti-chi-bot ti-chi-bot merged commit 877196e into pingcap:release-6.3 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.3 This PR is cherry-picked to release-6.3 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants