Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(engine): add DM sync_collation integration test #6808

Merged
merged 5 commits into from
Aug 23, 2022
Merged

test(engine): add DM sync_collation integration test #6808

merged 5 commits into from
Aug 23, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 19, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6776

What is changed and how it works?

as title

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 19, 2022
@lance6716

This comment was marked as resolved.

Sign in to view
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2022
@lance6716 lance6716 changed the title [WIP] test(engine): add DM sync_collation integration test test(engine): add DM sync_collation integration test Aug 22, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 22, 2022
@lance6716 lance6716 mentioned this pull request Aug 22, 2022
Closed
55 tasks
@lance6716 lance6716 requested review from amyangfei, sleepymole and GMHDBJD and removed request for amyangfei August 22, 2022 11:32
@lance6716
fix lint
2fb9c68 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2fb9c68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharlesCheung96
Copy link
Contributor

/hold please run engine integration test

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@CharlesCheung96
Copy link
Contributor

/run-engine-integration-test

@lance6716
Copy link
Contributor Author

lance6716 commented Aug 23, 2022 •
edited
Loading

@CharlesCheung96 engine integration test is not working at this time, because the other two tests rely on an unfinished feature "task left finish message while exit"

@CharlesCheung96
Copy link
Contributor

@CharlesCheung96 engine integration test is not working at this time, because the other two tests rely on an unfinished feature "task left finish message while exit"

Please add a TODO comment in corresponding cases.

@lance6716
Copy link
Contributor Author

@CharlesCheung96 engine integration test is not working at this time, because the other two tests rely on an unfinished feature "task left finish message while exit"

Please add a TODO comment in corresponding cases.

OK, I'll do it in next PR, very soon.

@CharlesCheung96
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@ti-chi-bot ti-chi-bot merged commit 60e9d95 into pingcap:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@maxshuang maxshuang maxshuang approved these changes

@sleepymole sleepymole sleepymole approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @ti-chi-bot @CharlesCheung96 @sleepymole @maxshuang