Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ticdc): add big txn integration test #5848

Merged
merged 9 commits into from
Jun 21, 2022
Merged

tests(ticdc): add big txn integration test #5848

merged 9 commits into from
Jun 21, 2022

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jun 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5231

What is changed and how it works?

  1. According to the analysis in sink(ticdc): remove force consume when redo is disabled #5712, increase per table quota to 35MB to improve sink throughput.
  2. Add an integration test for big txn (INSERT scenario, about 100MB per txn) to verify that cdc can properly sync transactions whose size exceeds the single-table quota.

Check List

Tests

  • Unit test
  • Integration test

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/ticdc Issues or PRs related to TiCDC. labels Jun 13, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the add_big_txn_integration_test branch from 6a451ea to 4b7071a Compare June 14, 2022 03:31
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 14, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the add_big_txn_integration_test branch from 9a4c339 to d4daf5d Compare June 15, 2022 03:20
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review June 15, 2022 03:54
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2022
@CharlesCheung96
Copy link
Contributor Author

/cc amyangfei
/cc asddongmen

@CharlesCheung96
Copy link
Contributor Author

/run-dm-integration-test

@3AceShowHand
Copy link
Contributor

LGTM

Please also consider the impact of set the default memory quota to 35MB.

It looks that this would cause OOM more easily, which may be due to a low memory mount or the huge amount of tables.

@ti-chi-bot ti-chi-bot requested a review from asddongmen June 21, 2022 04:39
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-test

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e5d3846

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1bd34f6 into pingcap:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus overvenus approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharlesCheung96 @ti-chi-bot @3AceShowHand @asddongmen @overvenus