Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use python3 to run http_api test to fix failed integration_tests #5473

Merged
merged 1 commit into from
May 19, 2022
Merged

tests: use python3 to run http_api test to fix failed integration_tests #5473

merged 1 commit into from
May 19, 2022

Conversation

zhangyangyu
Copy link
Member

@zhangyangyu zhangyangyu commented May 19, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5474

What is changed and how it works?

Our CI envs still default to python2 to run tests. http_api requires using requests which brings certifi. Actually certifi's recent releases doesn't support python2 any more.

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-linked-issue labels May 19, 2022
@zhangyangyu zhangyangyu added severity/moderate component/test Unit tests and integration tests component. labels May 19, 2022
@zhangyangyu
Copy link
Member Author

/run-check-issue-triage-complete

@zhangyangyu zhangyangyu removed severity/moderate component/test Unit tests and integration tests component. labels May 19, 2022
@zhangyangyu
Copy link
Member Author

/run-check-issue-triage-complete

@zhangyangyu
Copy link
Member Author

/run-leak-test

@zhangyangyu
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2022
@zhangyangyu
Copy link
Member Author

/run-verify

@zhangyangyu zhangyangyu changed the title tests: use python3 to run http_api test to fix integration_tests tests: use python3 to run http_api test to fix failed integration_tests May 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 06d2af3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@zhangyangyu
Copy link
Member Author

/run-integration-test

@zhangyangyu
Copy link
Member Author

/run-kafka-integration-test

@zhangyangyu
Copy link
Member Author

/run-kafka-integration-test

@zhangyangyu
Copy link
Member Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022 •
edited
Loading

Codecov Report

Merging #5473 (06d2af3) into master (7a80b61) will increase coverage by 0.3300%.
The diff coverage is 51.1784%.

Flag Coverage Δ
cdc 61.6099% <43.7500%> (+0.6457%) ⬆️
dm 52.0445% <68.5393%> (+0.0842%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5473        +/-   ##
================================================
+ Coverage   55.9233%   56.2533%   +0.3300%     
================================================
  Files           528        530         +2     
  Lines         69935      69962        +27     
================================================
+ Hits          39110      39356       +246     
+ Misses        27100      26857       -243     
- Partials       3725       3749        +24

@ti-chi-bot ti-chi-bot merged commit 7473aeb into pingcap:master May 19, 2022
@zhangyangyu zhangyangyu deleted the fix-ci branch May 19, 2022 08:16
@zhangyangyu zhangyangyu added needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. labels May 19, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 19, 2022
@zhangyangyu @ti-chi-bot
This is an automated cherry-pick of pingcap#5473
92ff68d 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 19, 2022
@zhangyangyu @ti-chi-bot
This is an automated cherry-pick of pingcap#5473
4bb0a57 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced May 19, 2022
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5478.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 19, 2022
@zhangyangyu @ti-chi-bot
This is an automated cherry-pick of pingcap#5473
4098660 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5479.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5480.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 19, 2022
@zhangyangyu @ti-chi-bot
This is an automated cherry-pick of pingcap#5473
0c1938a 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5481.

Rustin170506 pushed a commit that referenced this pull request Jun 14, 2022
@zhangyangyu @Rustin170506
This is an automated cherry-pick of #5473
0d11b63 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 14, 2022
@zhangyangyu @ti-chi-bot
This is an automated cherry-pick of pingcap#5473
fa4c87f 
Signed-off-by: ti-chi-bot <[email protected]>
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 14, 2022
@zhangyangyu @overvenus
tests: use python3 to run http_api test to fix failed integration_tes…
a85f646 
…ts (pingcap#5473)

close pingcap#5474
ti-chi-bot added a commit that referenced this pull request Jun 17, 2022
@ti-chi-bot
tests: use python3 to run http_api test to fix failed integration_tes…
a929076 
…ts (#5473) (#5481)

close #5474
ti-chi-bot added a commit that referenced this pull request Jun 21, 2022
@ti-chi-bot
tests: use python3 to run http_api test to fix failed integration_tes…
48e2761 
…ts (#5473) (#5480)

close #5474
overvenus pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 22, 2022
@zhangyangyu @overvenus
tests: use python3 to run http_api test to fix failed integration_tes…
29a0817 
…ts (pingcap#5473)

close pingcap#5474
hicqu pushed a commit to liuzix/ticdc that referenced this pull request Jun 25, 2022
@zhangyangyu @hicqu
tests: use python3 to run http_api test to fix failed integration_tes…
dc63f57 
…ts (pingcap#5473)

close pingcap#5474

Signed-off-by: qupeng <[email protected]>
sdojjy pushed a commit to sdojjy/tiflow that referenced this pull request Jul 21, 2022
@zhangyangyu @sdojjy
tests: use python3 to run http_api test to fix failed integration_tes…
11fbd4b 
…ts (pingcap#5473)

close pingcap#5474
# Conflicts:
#	tests/integration_tests/http_api/run.sh
@sdojjy sdojjy mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy sdojjy approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IT http_api fails
5 participants
@zhangyangyu @ti-chi-bot @3AceShowHand @codecov-commenter @sdojjy