-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): store checkpointTs by flushedResolvedTsMap in mysql sink (#5418) #5437
sink(ticdc): store checkpointTs by flushedResolvedTsMap in mysql sink (#5418) #5437
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
122c0e7
to
6286415
Compare
/run-all-tests |
/run-kafka-integration-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6286415
|
/run-kafka-integration-test |
This is an automated cherry-pick of #5418
What problem does this PR solve?
Issue Number: close #5107
What is changed and how it works?
When mysql Sink traverses the
tableMaxResolvedTs
at this line, the map may have been concurrently modified, which will result in an incorrect value being saved totableCheckpointTs
.To solve this problem, we need to:
Replace
resolvedNotifier
withresolvedCh
to simplify the codeCheck List
Tests
Related changes
Release note