-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): store checkpointTs by flushedResolvedTsMap in mysql sink (#5418) #5436
sink(ticdc): store checkpointTs by flushedResolvedTsMap in mysql sink (#5418) #5436
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
b0bec3c
to
826fed6
Compare
Codecov Report
@@ Coverage Diff @@
## release-5.3 #5436 +/- ##
================================================
Coverage ? 55.6663%
================================================
Files ? 224
Lines ? 23878
Branches ? 0
================================================
Hits ? 13292
Misses ? 9261
Partials ? 1325 |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 826fed6
|
/run-kafka-integration-tests |
/run-verify |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
This is an automated cherry-pick of #5418
What problem does this PR solve?
Issue Number: close #5107
What is changed and how it works?
When mysql Sink traverses the
tableMaxResolvedTs
at this line, the map may have been concurrently modified, which will result in an incorrect value being saved totableCheckpointTs
.To solve this problem, we need to:
Replace
resolvedNotifier
withresolvedCh
to simplify the codeCheck List
Tests
Related changes
Release note