Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink/flowcontrol(ticdc): make tests run and refactor code #5264

Merged
merged 6 commits into from
Apr 26, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Apr 25, 2022

What problem does this PR solve?

Issue Number: ref #5138

What is changed and how it works?

  • make tests run and using testify
  • refactor code, split file, rename fileds

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects
None
Related changes
None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 25, 2022
@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Apr 25, 2022
@Rustin170506 Rustin170506 force-pushed the rustin-patch-flowcontrol branch from 9047b44 to d26702b Compare April 25, 2022 07:05
@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #5264 (b837acb) into master (687e248) will increase coverage by 0.0695%.
The diff coverage is 52.0319%.

Flag Coverage Δ
cdc 61.1131% <52.0319%> (+0.5145%) ⬆️
dm 52.3515% <ø> (-0.1180%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5264        +/-   ##
================================================
+ Coverage   56.1240%   56.1935%   +0.0695%     
================================================
  Files           522        525         +3     
  Lines         65325      68426      +3101     
================================================
+ Hits          36663      38451      +1788     
- Misses        25094      26210      +1116     
- Partials       3568       3765       +197     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2022
@CharlesCheung96
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@CharlesCheung96: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 49ed662

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2022
@ti-chi-bot
Copy link
Member

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test
/run-verify

@Rustin170506
Copy link
Member Author

/run-verify

1 similar comment
@CharlesCheung96
Copy link
Contributor

/run-verify

@ti-chi-bot ti-chi-bot merged commit a7bcd92 into pingcap:master Apr 26, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-flowcontrol branch August 15, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants