Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM(syncer): fix syncer may be dead cycle when access match inject ddl repeatedly by special ddls #5016

Merged
merged 7 commits into from
Mar 29, 2022
Merged

DM(syncer): fix syncer may be dead cycle when access match inject ddl repeatedly by special ddls #5016

merged 7 commits into from
Mar 29, 2022

Conversation

WizardXiao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #5009

What is changed and how it works?

add check for repeatedly access match inject.

Check List

Tests

  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. labels Mar 25, 2022
@WizardXiao WizardXiao self-assigned this Mar 25, 2022
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 25, 2022
@WizardXiao WizardXiao added the area/dm Issues or PRs related to DM. label Mar 25, 2022
@WizardXiao
Copy link
Contributor Author

/cc @lance6716 @GMHDBJD

@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lance6716 March 25, 2022 01:53
@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-leak-test

@WizardXiao
Copy link
Contributor Author

/run-verify-ci

@codecov-commenter
Copy link

Codecov Report

Merging #5016 (20f5d3a) into master (687e248) will decrease coverage by 0.4338%.
The diff coverage is 53.2815%.

Flag Coverage Δ
cdc 61.1480% <44.4565%> (+0.5494%) ⬆️
dm 51.3515% <87.3949%> (-1.1180%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5016        +/-   ##
================================================
- Coverage   56.1240%   55.6901%   -0.4339%     
================================================
  Files           522        524         +2     
  Lines         65325      67265      +1940     
================================================
+ Hits          36663      37460       +797     
- Misses        25094      26100      +1006     
- Partials       3568       3705       +137

@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

GMHDBJD
GMHDBJD approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2022
@WizardXiao
Copy link
Contributor Author

/run-all-tests

@Ehco1996
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cce382e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@Ehco1996
Copy link
Contributor

/run-dm-integration-test

@Ehco1996
Copy link
Contributor

start DM-101 optimistic
/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit ca2fdd8 into pingcap:master Mar 29, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 29, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5057.

ti-chi-bot added a commit that referenced this pull request Mar 29, 2022
@ti-chi-bot
DM(syncer): fix syncer may be dead cycle when access match inject ddl…
0c38e62 
… repeatedly by special ddls (#5016) (#5057)

close #5009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees

@WizardXiao WizardXiao

Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM(syncer): syncer may be dead cycle when access match inject ddl repeatedly by special ddls
6 participants
@WizardXiao @ti-chi-bot @codecov-commenter @Ehco1996 @lance6716 @GMHDBJD