-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task_checker(dm): refactor and expose an auto resume function #5004
Conversation
Signed-off-by: lance6716 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-verify |
/run-dm-integration-test |
Signed-off-by: lance6716 <[email protected]>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5004 +/- ##
================================================
- Coverage 56.1240% 55.8553% -0.2687%
================================================
Files 522 523 +1
Lines 65325 66674 +1349
================================================
+ Hits 36663 37241 +578
- Misses 25094 25755 +661
- Partials 3568 3678 +110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7dd99f8
|
Can we make AutoResumeInfo as a default interface, and TaskAutoResume/RelayAutoResume implement the CheckResume and Resume func? just like the template method pattern |
left for future work🙈 |
/run-dm-integration-test |
Signed-off-by: lance6716 [email protected]
What problem does this PR solve?
Issue Number: ref #4287
What is changed and how it works?
as title. For dataflow engine, an unit can be checked auto resume by build an
AutoResumeTimes
andUpdateResumeStrategy
Check List
Tests
Code changes
Side effects
Related changes
Release note