Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router(dm): migrate router from dm to tidb-tools #4911

Merged
merged 11 commits into from
Mar 18, 2022
Merged

router(dm): migrate router from dm to tidb-tools #4911

merged 11 commits into from
Mar 18, 2022

Conversation

buchuitoudegou
Copy link
Contributor

@buchuitoudegou buchuitoudegou commented Mar 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4701

What is changed and how it works?

  • remove dm/pkg/router
  • introduce tidb-tools/regexpr-router

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 16, 2022
@buchuitoudegou buchuitoudegou added the area/dm Issues or PRs related to DM. label Mar 16, 2022
@buchuitoudegou
Copy link
Contributor Author

I will add some integration tests later.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #4911 (0fbb4a3) into master (687e248) will decrease coverage by 0.3732%.
The diff coverage is 59.9137%.

Flag Coverage Δ
cdc 60.9547% <52.7777%> (+0.3561%) ⬆️
dm 51.5936% <63.6125%> (-0.8759%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4911        +/-   ##
================================================
- Coverage   56.1240%   55.7507%   -0.3733%     
================================================
  Files           522        523         +1     
  Lines         65325      66652      +1327     
================================================
+ Hits          36663      37159       +496     
- Misses        25094      25835       +741     
- Partials       3568       3658        +90

@buchuitoudegou buchuitoudegou added the status/ptal Could you please take a look? label Mar 17, 2022
@buchuitoudegou
Copy link
Contributor Author

/run-all-tests

Ehco1996
Ehco1996 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022
@Ehco1996
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0fbb4a3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2022
@buchuitoudegou
Copy link
Contributor Author

/run-kafka-integration-test

@buchuitoudegou
Copy link
Contributor Author

/run-integration-test

@buchuitoudegou
Copy link
Contributor Author

/run-dm-compatibility-test

@buchuitoudegou
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 9d718db into pingcap:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible table router in DM and Lightning
5 participants
@buchuitoudegou @ti-chi-bot @codecov-commenter @Ehco1996 @lance6716