Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(master/shardddl): migrate test-infra to testify for master/shardddl pkg #4893

Merged
merged 12 commits into from
Mar 16, 2022
Merged

test(master/shardddl): migrate test-infra to testify for master/shardddl pkg #4893

merged 12 commits into from
Mar 16, 2022

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #2164

What is changed and how it works?

  1. migrate test-infra from gocheck to testify
  2. fix a bug that optimistic may get blocked when we employ o.Close.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note 

None.

@lichunzhu lichunzhu added type/bugfix This PR fixes a bug. component/test Unit tests and integration tests component. severity/minor area/dm Issues or PRs related to DM. labels Mar 15, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 15, 2022
@lichunzhu
Copy link
Contributor Author

/run-verify-ci

@codecov-commenter
Copy link

Codecov Report

Merging #4893 (81017d7) into master (687e248) will increase coverage by 0.2011%.
The diff coverage is 56.4433%.

Flag Coverage Δ
cdc 60.9604% <56.5826%> (+0.3618%) ⬆️
dm 52.5137% <54.8387%> (+0.0442%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4893        +/-   ##
================================================
+ Coverage   56.1240%   56.3251%   +0.2011%     
================================================
  Files           522        524         +2     
  Lines         65325      65532       +207     
================================================
+ Hits          36663      36911       +248     
+ Misses        25094      25024        -70     
- Partials       3568       3597        +29

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu lichunzhu mentioned this pull request Mar 16, 2022
Merged
@lichunzhu
Copy link
Contributor Author

/run-leak-test

GMHDBJD
GMHDBJD approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Mar 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d2abd58

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
Ehco1996
Ehco1996 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot merged commit 50c98a6 into pingcap:master Mar 16, 2022
@lichunzhu lichunzhu deleted the shardddlUTUpgrade branch March 16, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. severity/minor size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lichunzhu @ti-chi-bot @codecov-commenter @GMHDBJD @lance6716 @Ehco1996