Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator(dm): fast mode validation #4754

Merged
merged 9 commits into from
Mar 14, 2022
Merged

validator(dm): fast mode validation #4754

merged 9 commits into from
Mar 14, 2022

Conversation

buchuitoudegou
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4716

What is changed and how it works?

  1. extract mode config from subtask config
  2. only validate PK/UK

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 3, 2022
@buchuitoudegou buchuitoudegou added area/dm Issues or PRs related to DM. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 3, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 10, 2022
@buchuitoudegou buchuitoudegou changed the title [WIP] validator(dm): fast mode validation validator(dm): fast mode validation Mar 10, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@buchuitoudegou buchuitoudegou requested a review from D3Hunter March 10, 2022 08:30
lance6716
lance6716 reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dm/syncer/data_validator.go Outdated Show resolved Hide resolved
@buchuitoudegou
Copy link
Contributor Author

/run-verify

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022 •
edited
Loading

Codecov Report

Merging #4754 (c9ce6c5) into master (9607554) will increase coverage by 0.6722%.
The diff coverage is 70.9349%.

Flag Coverage Δ
cdc 60.9367% <70.9349%> (+1.0145%) ⬆️
dm 52.5098% <ø> (+0.4809%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4754        +/-   ##
================================================
+ Coverage   55.6402%   56.3124%   +0.6722%     
================================================
  Files           494        524        +30     
  Lines         61283      65529      +4246     
================================================
+ Hits          34098      36901      +2803     
- Misses        23750      25028      +1278     
- Partials       3435       3600       +165

D3Hunter
D3Hunter reviewed Mar 14, 2022
View reviewed changes
dm/dm/worker/subtask.go Outdated Show resolved Hide resolved
dm/syncer/data_validator.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 14, 2022
@D3Hunter
Copy link
Contributor

/run-all-tests

@buchuitoudegou
Copy link
Contributor Author

/run-verify

@buchuitoudegou
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ceca0b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@ti-chi-bot ti-chi-bot merged commit 461b98f into pingcap:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validator(dm): fast validation mode
5 participants
@buchuitoudegou @ti-chi-bot @codecov-commenter @D3Hunter @lance6716