Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/codec: fix nil value in canal codec. #4741

Merged
merged 2 commits into from
Mar 2, 2022
Merged

cdc/codec: fix nil value in canal codec. #4741

merged 2 commits into from
Mar 2, 2022

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4736

What is changed and how it works?

check nil before use the Column.Value in Canal

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

fix `Canal-JSON` meet `unsigned` SQL Type and nullable, which cause CDC server panic.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • liuzix
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Mar 2, 2022
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2022
@maxshuang
Copy link
Contributor

/run-verify
/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 549032a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@3AceShowHand
Copy link
Contributor Author

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 21e7eb6 into pingcap:master Mar 2, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 2, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4741
69199cd 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 2, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4745.

3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Apr 11, 2022
@3AceShowHand
cdc/codec: fix nil value in canal codec. (pingcap#4741)
6d66e76 
close pingcap#4736
ti-chi-bot added a commit that referenced this pull request Apr 27, 2022
@ti-chi-bot
cdc/codec: fix nil value in canal codec. (#4741) (#4745)
2f8ce64 
close #4736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzix liuzix liuzix approved these changes

@maxshuang maxshuang maxshuang approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

canal_json don't support nil value for uint64
4 participants
@3AceShowHand @ti-chi-bot @maxshuang @liuzix