Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/kafka: 5.3-manaual-cherry-pick-for-kafka-configuration #4641

Merged
merged 11 commits into from
Feb 21, 2022
Merged

cdc/kafka: 5.3-manaual-cherry-pick-for-kafka-configuration #4641

merged 11 commits into from
Feb 21, 2022

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Feb 21, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4385 #4383 #4499

What is changed and how it works?

This is a manual cherry-pick of #4526 #4541

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 21, 2022
@3AceShowHand 3AceShowHand changed the title cdc/kafka: manaully cherry-pick cdc/kafka: 5.3-manaual-cherry-pick-for-kafka-configuration Feb 21, 2022
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 21, 2022
@asddongmen asddongmen added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 21, 2022
@asddongmen
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 03e715c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@9d50aba). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.3      #4641   +/-   ##
================================================
  Coverage               ?   55.3871%           
================================================
  Files                  ?        221           
  Lines                  ?      23621           
  Branches               ?          0           
================================================
  Hits                   ?      13083           
  Misses                 ?       9227           
  Partials               ?       1311

@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66cdc4c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit f034233 into pingcap:release-5.3 Feb 21, 2022
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus overvenus approved these changes

@liuzix liuzix Awaiting requested review from liuzix

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
7 participants
@3AceShowHand @ti-chi-bot @asddongmen @codecov-commenter @overvenus @VelocityLight @purelind