-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc/codec: fix string for unsigned value in canal-json. #4629
cdc/codec: fix string for unsigned value in canal-json. #4629
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4629 +/- ##
================================================
- Coverage 55.6402% 55.4897% -0.1505%
================================================
Files 494 508 +14
Lines 61283 63309 +2026
================================================
+ Hits 34098 35130 +1032
- Misses 23750 24686 +936
- Partials 3435 3493 +58 |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4ff0b1f
|
@3AceShowHand: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-integration-test /tidb=pr/32434 |
In response to a cherrypick label: new pull request created: #4657. |
What problem does this PR solve?
Issue Number: close #4635
What is changed and how it works?
handle the case when
unsigned
instring
Check List
Tests
Code changes
Side effects
Related changes
Release note