Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ticdc): migrate test-infra to testify for several pkg #4626

Merged
merged 7 commits into from
Mar 13, 2022
Merged

tests(ticdc): migrate test-infra to testify for several pkg #4626

merged 7 commits into from
Mar 13, 2022

Conversation

CharlesCheung96
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #2904, #2905, #2906

What is changed and how it works?

Migrate all test cases under cdc/puller and cdc/sorter to testify.

Check List

Tests

  • Unit test

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 18, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-tests
/run-integration-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2022
@overvenus overvenus added the component/test Unit tests and integration tests component. label Feb 23, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 24, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the fix_2904_migrate_cdc_puller branch from 16b3e7d to 9cf93e5 Compare February 24, 2022 03:52
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022 •
edited
Loading

Codecov Report

Merging #4626 (0254f58) into master (9607554) will increase coverage by 0.6902%.
The diff coverage is 70.9349%.

Flag Coverage Δ
cdc 60.9957% <70.9349%> (+1.0734%) ⬆️
dm 52.4945% <ø> (+0.4656%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4626        +/-   ##
================================================
+ Coverage   55.6402%   56.3305%   +0.6902%     
================================================
  Files           494        523        +29     
  Lines         61283      65524      +4241     
================================================
+ Hits          34098      36910      +2812     
- Misses        23750      25019      +1269     
- Partials       3435       3595       +160

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

2 similar comments
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-tests
/run-leak-tests
/run-verify

@CharlesCheung96
Copy link
Contributor Author

/
/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

3 similar comments
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the fix_2904_migrate_cdc_puller branch from 7cdffd7 to 7c1daf7 Compare March 2, 2022 05:34
@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-tests
/run-integration-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-tests
/run-integration-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

2 similar comments
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96 CharlesCheung96 force-pushed the fix_2904_migrate_cdc_puller branch from 6c5d11d to 3b279ff Compare March 9, 2022 05:56
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-leak-test

@CharlesCheung96 CharlesCheung96 added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27330b4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2022
@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/run-verify
/run-integration-test

@overvenus
Copy link
Member

/run-verify

@ti-chi-bot ti-chi-bot merged commit 2b2fd58 into pingcap:master Mar 13, 2022
This was referenced Apr 25, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@ben1009 ben1009 ben1009 approved these changes

Assignees
No one assigned
Labels
component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for cdc/puller pkg
5 participants
@CharlesCheung96 @ti-chi-bot @codecov-commenter @overvenus @ben1009