Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader(dm): skip feature for nil etcd client #4599

Merged
merged 1 commit into from
Feb 16, 2022
Merged

loader(dm): skip feature for nil etcd client #4599

merged 1 commit into from
Feb 16, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Feb 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

When use DM as a library, sometimes etcd client is not valid thus we should support nil etcd client

Check List

Tests

  • pass original tests

Code changes

Side effects

Related changes

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2022
@lance6716 lance6716 changed the title [WIP]loader(dm): skip nil etcd client loader(dm): skip feature for nil etcd client Feb 16, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 16, 2022
@lance6716 lance6716 added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 16, 2022
GMHDBJD
GMHDBJD approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 16, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27a2351

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Feb 16, 2022
@ti-chi-bot ti-chi-bot merged commit 744a26e into pingcap:master Feb 16, 2022
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@lance6716 @zhaoxinyu
loader(dm): skip feature for nil etcd client (pingcap#4599)
19b3a40 
ref pingcap#4287
@lance6716 lance6716 deleted the load-nil-etcdcli branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @ti-chi-bot @GMHDBJD