Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported data type issue caused by default value filling logic #4518

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Fix unsupported data type issue caused by default value filling logic #4518

merged 3 commits into from
Feb 8, 2022

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

This is a manual pr merge(#3846 #4224 #3930)

Issue Number: close #3793 #4223 #3929 #3918

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

Support more data types with default value attribute, and fix potential data inconsistency caused by default value logic

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 8, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@618e794). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #4518   +/-   ##
================================================
  Coverage               ?   62.3300%           
================================================
  Files                  ?        162           
  Lines                  ?      17064           
  Branches               ?          0           
================================================
  Hits                   ?      10636           
  Misses                 ?       5525           
  Partials               ?        903           

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test
/run-integration-test

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 8, 2022
@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test
/run-integration-test

@overvenus overvenus added tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. status/can-merge Indicates a PR has been approved by a committer. labels Feb 8, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2022
@overvenus overvenus added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2022
@overvenus overvenus merged commit d9af323 into pingcap:release-5.1 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants