Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix non-unique index info in schema storage test #4371

Merged
merged 5 commits into from
Jan 19, 2022

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #1485

What is changed and how it works?

Fix unit test, the test adds an index (non-unique index) to an ineligible table, and the table keeps ineligible.

This PR fixes unit test only, doesn't change the behavior in #1485

Check List

Tests

  • Unit test

Release note

None

@amyangfei amyangfei added component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2022
@amyangfei amyangfei added the status/ptal Could you please take a look? label Jan 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2022
@amyangfei
Copy link
Contributor Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #4371 (e408162) into master (ab62e6b) will decrease coverage by 0.0933%.
The diff coverage is 44.6559%.

Flag Coverage Δ
cdc 59.3161% <54.6042%> (-0.2998%) ⬇️
dm 52.1427% <40.3496%> (+0.0771%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4371        +/-   ##
================================================
- Coverage   55.5183%   55.4249%   -0.0934%     
================================================
  Files           495        495                
  Lines         61151      61171        +20     
================================================
- Hits          33950      33904        -46     
- Misses        23789      23848        +59     
- Partials       3412       3419         +7     

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e408162

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2022
@amyangfei
Copy link
Contributor Author

/run-leak-test
/run-dm-integration-test

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-leak-test
/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4406.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4407.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4408.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4409.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4410.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants