Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source_worker(dm): peroidically update source metrics background #4330

Merged
merged 3 commits into from
Jan 14, 2022
Merged

source_worker(dm): peroidically update source metrics background #4330

merged 3 commits into from
Jan 14, 2022

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4281

What is changed and how it works?

as title

Check List

Tests

  • Integration test

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note 

Fix a bug that upstream metrics won't update if no query-status

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 14, 2022
@lance6716 lance6716 added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 14, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2022
@lance6716
Copy link
Contributor Author

/cc @glorv @niubell

@ti-chi-bot ti-chi-bot requested review from glorv and niubell January 14, 2022 06:28
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD

@ti-chi-bot ti-chi-bot requested a review from GMHDBJD January 14, 2022 06:29
@glorv glorv added the area/dm Issues or PRs related to DM. label Jan 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2022
GMHDBJD
GMHDBJD approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 14, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 05bd821

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 14, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@niubell: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@niubell
Copy link
Contributor

niubell commented Jan 14, 2022

LGTM

@lance6716
Copy link
Contributor Author

/run-kafka-integration-test
/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit d24f962 into pingcap:master Jan 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 14, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4332.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 14, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4333.

ti-chi-bot added a commit that referenced this pull request Jan 14, 2022
@ti-chi-bot
source_worker(dm): peroidically update source metrics background (#4330…
aaea432 
…) (#4333)

close #4281
ti-chi-bot added a commit that referenced this pull request Jan 16, 2022
@ti-chi-bot
source_worker(dm): peroidically update source metrics background (#4330…
9779df7 
…) (#4332)

close #4281
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
@lance6716 @zhaoxinyu
source_worker(dm): peroidically update source metrics background (pin…
b54d030 
…gcap#4330)

close pingcap#4281
@lance6716 lance6716 deleted the fix-4281 branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@niubell niubell niubell approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some metrics of Syncer is not updated if no query-status
5 participants
@lance6716 @ti-chi-bot @niubell @glorv @GMHDBJD