-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(ticdc): Migrate test cases to testify for pkg/etcd #4219
tests(ticdc): Migrate test cases to testify for pkg/etcd #4219
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4219 +/- ##
================================================
- Coverage 55.1722% 55.1701% -0.0021%
================================================
Files 485 488 +3
Lines 59829 60801 +972
================================================
+ Hits 33009 33544 +535
- Misses 23484 23874 +390
- Partials 3336 3383 +47 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 187ff11
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 93444d8
|
@zhaoxinyu: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #2878
What is changed and how it works?
Migrate all test cases under pkg/etcd to testify.
Check List
Tests
Release note