-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mounter(ticdc): fix mounter add default value type unsupported (#3846) #3855
mounter(ticdc): fix mounter add default value type unsupported (#3846) #3855
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@VelocityLight: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 04da6cf
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3855 +/- ##
===================================================
+ Coverage 53.7661% 57.0958% +3.3297%
===================================================
Files 153 170 +17
Lines 15958 19772 +3814
===================================================
+ Hits 8580 11289 +2709
- Misses 6475 7421 +946
- Partials 903 1062 +159 |
/merge |
This is an automated cherry-pick of #3846
close #3793
What problem does this PR solve?
Fix default value unsupported bug cause by amend feature of tidb, related to issue #3793
Amend feature of TiDB:
As for add column DDL, if a DDL occur between a trx, the trx will not redo but commit the old schema data directly, which will cause TiCDC use new schema to parse old schema data.
What is changed and how it works?
After call "getDefaultOrZeroValue", we need to call "formatColVal" to format data from the tidb type to go supported sql type
Check List
Tests
Start 2 transactions:
Code changes
Side effects
Related changes
Release note