Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter(ticdc): fix mounter add default value type unsupported (#3846) #3855

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3846

close #3793

What problem does this PR solve?

Fix default value unsupported bug cause by amend feature of tidb, related to issue #3793

Amend feature of TiDB:
As for add column DDL, if a DDL occur between a trx, the trx will not redo but commit the old schema data directly, which will cause TiCDC use new schema to parse old schema data.

What is changed and how it works?

After call "getDefaultOrZeroValue", we need to call "formatColVal" to format data from the tidb type to go supported sql type

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Start 2 transactions:
  1. Transaction 1:
Create table test_column(id int primary key);
Insert Into test_column values(1);
begin;
Insert Into test_column values(2);
// hold the trx untill Transaction 2 commit DDL
commit;
  • Transaction 2:
alter table test_column add column c0 date not null;

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

Fix mounter default date value not support

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 13, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Dec 13, 2021
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 13, 2021
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member Author

@VelocityLight: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 04da6cf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 13, 2021
@purelind
Copy link
Collaborator

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #3855 (9dec583) into release-4.0 (753073a) will increase coverage by 3.3297%.
The diff coverage is 67.1237%.

@@                 Coverage Diff                 @@
##           release-4.0      #3855        +/-   ##
===================================================
+ Coverage      53.7661%   57.0958%   +3.3297%     
===================================================
  Files              153        170        +17     
  Lines            15958      19772      +3814     
===================================================
+ Hits              8580      11289      +2709     
- Misses            6475       7421       +946     
- Partials           903       1062       +159     

@overvenus
Copy link
Member

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants