-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(ticdc): Fix old value configuration check for maxwell protocol (#3747) #3781
config(ticdc): Fix old value configuration check for maxwell protocol (#3747) #3781
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
8bd2578
to
eab536b
Compare
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: eab536b
|
Codecov Report
@@ Coverage Diff @@
## release-5.1 #3781 +/- ##
================================================
Coverage ? 64.4096%
================================================
Files ? 160
Lines ? 16718
Branches ? 0
================================================
Hits ? 10768
Misses ? 5005
Partials ? 945 |
This is an automated cherry-pick of #3747 and #3983
What problem does this PR solve?
close https://github.com/pingcap/ticdc/issues/3676
What is changed and how it works?
Check List
Tests
Unit test
Manual test(https://github.com/pingcap/ticdc/pull/3747#issuecomment-986629511)
Code changes
Has exported function/method change
Has exported variable/fields change
Side effects
None
Related changes
Release note