Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workerpool: limit the rate to output deadlock warning #3775

Merged
merged 7 commits into from
Dec 8, 2021
Merged

workerpool: limit the rate to output deadlock warning #3775

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be723a2
workerpool: limit the rate to output deadlock warning
liuzix Sep 3, 2021
5768d3a
add a test
overvenus Dec 8, 2021
dc0f37f
address comments
overvenus Dec 8, 2021
68c199c
Merge branch 'master' into fix-deadlock-log
ti-chi-bot Dec 8, 2021
9226de4
fix data race
overvenus Dec 8, 2021
a819919
Merge branch 'fix-deadlock-log' of github.com:overvenus/ticdc into fi…
overvenus Dec 8, 2021
7afc32c
Merge branch 'master' into fix-deadlock-log
ti-chi-bot Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/workerpool/pool_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package workerpool

import (
"context"
"golang.org/x/time/rate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved down to the second group of imports?

"sync"
"sync/atomic"
"time"
Expand Down Expand Up @@ -386,6 +387,7 @@ func (w *worker) synchronize() {
}
defer receiver.Stop()

rl := rate.NewLimiter(rate.Every(time.Second * 5), 1)
startTime := time.Now()
for {
workerHasFinishedLoop := false
Expand All @@ -398,7 +400,7 @@ func (w *worker) synchronize() {
break
}

if time.Since(startTime) > time.Second*10 {
if time.Since(startTime) > time.Second*10 && rl.Allow(){
// likely the workerpool has deadlocked, or there is a bug in the event handlers.
log.Warn("synchronize is taking too long, report a bug", zap.Duration("elapsed", time.Since(startTime)))
}
Expand Down