-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner_test (ticdc): fix unstable case TestHandleJobsDontBlock #3601
owner_test (ticdc): fix unstable case TestHandleJobsDontBlock #3601
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you summarize the problem in the PR description?
/run-leak-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Codecov Report
@@ Coverage Diff @@
## master #3601 +/- ##
================================================
+ Coverage 56.5356% 58.1023% +1.5666%
================================================
Files 211 241 +30
Lines 22798 24493 +1695
================================================
+ Hits 12889 14231 +1342
- Misses 8598 8839 +241
- Partials 1311 1423 +112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
@sdojjy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-kafka-integration-test |
…o fix_TestHandleJobsDontBlock
/run-integration-tests |
/run-kafka-integration-test |
Co-authored-by: Zixiong Liu <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b8da81e
|
/run-integration-tests |
/run-integration-tests |
@asddongmen: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
fix unstable case TestHandleJobsDontBlock
https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_leak_test/detail/cdc_ghpr_leak_test/12669/pipeline/
What is changed and how it works?
time.sleep()
, the latter will interferes this ut case.owner.tick
will be called after statusProvider.GetAllChangeFeedInfo(ctx1) be called, otherwise the request will not be handle, so thectx1
will timeout.Check List
Tests
Code changes
Side effects
Related changes
Release note