Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink/mysql: remove default schema in mysql dsn #353

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Fix pingcap/ticdc#320

What is changed and how it works?

the schema test may not exist in downstream, we can omit schema name in MySQL DSN

Check List

Tests

  • Unit test
  • Integration test

@amyangfei amyangfei added the component/sink Sink component. label Mar 19, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Mar 19, 2020
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit 137e959 into pingcap:master Mar 19, 2020
@amyangfei amyangfei deleted the fix-unknown-database branch March 26, 2020 10:24
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sink Sink component. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create database failed if the schema test does not exist in downstream
2 participants