Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema_storage: verbose DDL log #3187

Merged
merged 7 commits into from
Oct 30, 2021
Merged

schema_storage: verbose DDL log #3187

merged 7 commits into from
Oct 30, 2021

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Verbose some critical logs.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@overvenus overvenus added component/ddl DDL component. component/metrics-logging Metrics and logging component. labels Oct 29, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2021
amyangfei
amyangfei reviewed Oct 29, 2021
View reviewed changes
cdc/entry/schema_storage.go Outdated Show resolved Hide resolved
cdc/entry/schema_storage.go Outdated Show resolved Hide resolved
cdc/entry/schema_storage.go
@@ -719,11 +723,14 @@ func (s *schemaStorageImpl) GetSnapshot(ctx context.Context, ts uint64) (*schema
// The infinite retry here is a temporary solution to the `ErrSchemaStorageUnresolved` caused by
// DDL puller lagging too much.
startTime := time.Now()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startTime is not used somewhere else

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2021
overvenus and others added 2 commits October 29, 2021 16:34
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cf17861

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 29, 2021
@overvenus overvenus added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Oct 29, 2021
@ti-chi-bot
Copy link
Member

@overvenus: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

3AceShowHand
3AceShowHand reviewed Oct 30, 2021
View reviewed changes
cdc/entry/schema_storage.go
err := retry.Do(ctx, func() error {
var err error
snap, err = s.getSnapshot(ts)
if time.Since(startTime) >= 5*time.Minute && isRetryable(err) {
now := time.Now()
if now.Sub(logTime) >= 30*time.Second && isRetryable(err) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about use time.Since

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time.Since calls time.Now() internally, and time.Now() invokes a syscall clock_gettime. The current approach is more performant.

@overvenus
Copy link
Member Author

/run-kafka-tests
/run-integration-tests

1 similar comment
@overvenus
Copy link
Member Author

/run-kafka-tests
/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #3187 (f553e2b) into master (3c3b915) will decrease coverage by 0.3445%.
The diff coverage is 50.9227%.

@@               Coverage Diff                @@
##             master      #3187        +/-   ##
================================================
- Coverage   57.2251%   56.8805%   -0.3446%     
================================================
  Files           163        211        +48     
  Lines         19453      22709      +3256     
================================================
+ Hits          11132      12917      +1785     
- Misses         7261       8479      +1218     
- Partials       1060       1313       +253

@overvenus
Copy link
Member Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit d501b28 into pingcap:master Oct 30, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3197.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3198.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3199.

This was referenced Oct 30, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3200.

ti-chi-bot added a commit that referenced this pull request Nov 1, 2021
@ti-chi-bot
schema_storage: verbose DDL log (#3187) (#3200)
dc4a23e
ti-chi-bot added a commit that referenced this pull request Nov 1, 2021
@ti-chi-bot
schema_storage: verbose DDL log (#3187) (#3199)
0fe56b1
ti-chi-bot added a commit that referenced this pull request Nov 1, 2021
@ti-chi-bot
schema_storage: verbose DDL log (#3187) (#3197)
be76bd7
ti-chi-bot added a commit that referenced this pull request Nov 2, 2021
@ti-chi-bot
schema_storage: verbose DDL log (#3187) (#3198)
6c26fa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand left review comments

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
component/ddl DDL component. component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@overvenus @ti-chi-bot @amyangfei @codecov-commenter @3AceShowHand @asddongmen