-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv/client: use region based rate limiter and decouple it from event handler (#3118) #3131
kv/client: use region based rate limiter and decouple it from event handler (#3118) #3131
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 28b1779
|
/run-integration-tests |
3 similar comments
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3131 +/- ##
===================================================
+ Coverage 53.7661% 57.3302% +3.5641%
===================================================
Files 153 164 +11
Lines 15958 19515 +3557
===================================================
+ Hits 8580 11188 +2608
- Misses 6475 7265 +790
- Partials 903 1062 +159 |
This is an automated cherry-pick of #3118
What problem does this PR solve?
To fix part of #3110
If blocking happens in region worker because of rate limit, the receiving buffer of gRPC connection could be full and cause congestion in a gRPC channel, which would lead to back pressure in TiKV and slow incremental scan.
What is changed and how it works?
After this PR
Before this PR
Check List
Tests
Existing unit tests have covered the functional of change, the performance benchmark is launched manuall.
Release note