Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(entry): migrate test-infra to testify for cdc/entry pkg #2833

Merged
merged 3 commits into from
Sep 16, 2021
Merged

test(entry): migrate test-infra to testify for cdc/entry pkg #2833

merged 3 commits into from
Sep 16, 2021

Conversation

maxshuang
Copy link
Contributor

@maxshuang maxshuang commented Sep 15, 2021

What problem does this PR solve?

migrate test-infra to testify for cdc/entry pkg #2826

What is changed and how it works?

  1. migrate gocheck to testify, migrate testleak to goleak
  2. change tidb dependency to commit 0854595a6992 for new testkit
  3. move tidb/util/testkit pkg to tidb/testkit

Check List

Tests

  • Unit test
  • Integration test

Release note

migrate test-infra to testify for cdc/entry pkg

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2021
@maxshuang maxshuang added the component/test Unit tests and integration tests component. label Sep 15, 2021
@maxshuang maxshuang marked this pull request as draft September 16, 2021 01:45
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2021
@maxshuang
Copy link
Contributor Author

/run-integration-tests

@maxshuang maxshuang marked this pull request as ready for review September 16, 2021 02:34
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2021
@maxshuang
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"go.uber.org/goleak"
)

func TestMain(m *testing.M) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see TestMain in other PRs, can it be extracted into a function and reused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the package level function. Before all other test-case in any *_test.go, TestMain will be called firstly to do some initialization work.

I don't think it can be wrapped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract following code?

package somepkg

func SetupGoLeak(m *testing.M) {
	opts := []goleak.Option{
		goleak.IgnoreTopFunction("go.etcd.io/etcd/pkg/logutil.(*MergeLogger).outputLoop"),
		goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
	}

	goleak.VerifyTestMain(m, opts...)
}

// -------

package otherpkg

import somepkg

func TestMain(m *testing.M) {
    somepkg.SetupGoLeak(m)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But i am not sure if SetupGoLeak is so common that need to be wrapped. Some pkgs will add other stack functions.

I will check later.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6ac15bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@ti-chi-bot
Copy link
Member

@maxshuang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

Merging #2833 (b0feb7f) into master (11e574c) will increase coverage by 3.0830%.
The diff coverage is 55.3668%.

@@               Coverage Diff                @@
##             master      #2833        +/-   ##
================================================
+ Coverage   55.3406%   58.4237%   +3.0830%     
================================================
  Files           164        180        +16     
  Lines         19754      18905       -849     
================================================
+ Hits          10932      11045       +113     
+ Misses         7790       6865       -925     
+ Partials       1032        995        -37     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants