-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(entry): migrate test-infra to testify for cdc/entry pkg #2833
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-integration-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"go.uber.org/goleak" | ||
) | ||
|
||
func TestMain(m *testing.M) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see TestMain
in other PRs, can it be extracted into a function and reused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the package level function. Before all other test-case in any *_test.go, TestMain will be called firstly to do some initialization work.
I don't think it can be wrapped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract following code?
package somepkg
func SetupGoLeak(m *testing.M) {
opts := []goleak.Option{
goleak.IgnoreTopFunction("go.etcd.io/etcd/pkg/logutil.(*MergeLogger).outputLoop"),
goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
}
goleak.VerifyTestMain(m, opts...)
}
// -------
package otherpkg
import somepkg
func TestMain(m *testing.M) {
somepkg.SetupGoLeak(m)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But i am not sure if SetupGoLeak is so common that need to be wrapped. Some pkgs will add other stack functions.
I will check later.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6ac15bd
|
@maxshuang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## master #2833 +/- ##
================================================
+ Coverage 55.3406% 58.4237% +3.0830%
================================================
Files 164 180 +16
Lines 19754 18905 -849
================================================
+ Hits 10932 11045 +113
+ Misses 7790 6865 -925
+ Partials 1032 995 -37 |
What problem does this PR solve?
migrate test-infra to testify for cdc/entry pkg #2826
What is changed and how it works?
Check List
Tests
Release note