Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner: ignore duplicated DDL job in ddl puller #2423

Merged
merged 3 commits into from
Aug 3, 2021
Merged

owner: ignore duplicated DDL job in ddl puller #2423

merged 3 commits into from
Aug 3, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Fix #2422

What is changed and how it works?

Since the output of ddl puller is sorted, but can be duplicated, we add a lastDDLJobID to filter out duplicated DDL job.

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix a bug that owner could meet ErrSchemaStorageTableMiss error and reset a changefeed by accident.

@amyangfei amyangfei added type/bugfix This PR fixes a bug. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jul 30, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@amyangfei amyangfei added this to the v5.2.0 milestone Jul 30, 2021
@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 30, 2021
@ti-chi-bot ti-chi-bot requested review from liuzix and overvenus July 30, 2021 09:23
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2021
@amyangfei
Copy link
Contributor Author

/run-leak-tests

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2423 (cd73371) into master (5a4568b) will decrease coverage by 1.3047%.
The diff coverage is 43.1679%.

@@               Coverage Diff                @@
##             master      #2423        +/-   ##
================================================
- Coverage   57.0620%   55.7572%   -1.3048%     
================================================
  Files           165        170         +5     
  Lines         19435      20435      +1000     
================================================
+ Hits          11090      11394       +304     
- Misses         7288       7945       +657     
- Partials       1057       1096        +39

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cd73371

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@amyangfei
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 15e53d9 into pingcap:master Aug 3, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2457.

This was referenced Aug 3, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2458.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2459.

ti-chi-bot added a commit that referenced this pull request Aug 4, 2021
@ti-chi-bot
owner: ignore duplicated DDL job in ddl puller (#2423) (#2459)
09b438c
ti-chi-bot added a commit that referenced this pull request Aug 4, 2021
@ti-chi-bot
owner: ignore duplicated DDL job in ddl puller (#2423) (#2457)
d2277db
ti-chi-bot added a commit that referenced this pull request Aug 4, 2021
@ti-chi-bot
owner: ignore duplicated DDL job in ddl puller (#2423) (#2458)
0d77b34
@amyangfei amyangfei deleted the fix-duplicated-ddl branch August 16, 2021 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@lance6716 lance6716 lance6716 approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.

Owner met ErrSchemaStorageTableMiss error in integration test changefeed_pause_resume
5 participants
@amyangfei @ti-chi-bot @codecov-commenter @lance6716 @overvenus