Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Make changefeed sort dir visible (#2222) #2241

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2222

What problem does this PR solve?

This PR try to revert part of the work in #1784, also fix a problem when try to set data-dir by existed changefeed information.

  • sort-dir can be read but cannot be written.
  • create dir temporarily when try to find best data-dir by existed changefeed information.

What is changed and how it works?

revert changefeed info struct and related read and write.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

  • No release note

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jul 7, 2021
@ti-chi-bot ti-chi-bot requested review from zier-one and liuzix July 7, 2021 12:13
@ti-chi-bot ti-chi-bot requested a review from overvenus July 7, 2021 12:13
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 8, 2021
@3AceShowHand
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot
Copy link
Member Author

Merge canceled because a new commit is pushed.

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor

/run-leak-tests

@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@3AceShowHand: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@5d1554b). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #2241   +/-   ##
================================================
  Coverage               ?   52.4175%           
================================================
  Files                  ?        164           
  Lines                  ?      17683           
  Branches               ?          0           
================================================
  Hits                   ?       9269           
  Misses                 ?       7425           
  Partials               ?        989           

@3AceShowHand 3AceShowHand merged commit 9f014ba into pingcap:release-5.0 Jul 9, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants