-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: Make changefeed sort dir visible (#2222) #2239
cmd: Make changefeed sort dir visible (#2222) #2239
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Merge canceled because a new commit is pushed. |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #2222
What problem does this PR solve?
This PR try to revert part of the work in #1784, also fix a problem when try to set data-dir by existed changefeed information.
sort-dir
can be read but cannot be written.What is changed and how it works?
revert changefeed info struct and related read and write.
Check List
Tests
Code changes
Side effects
Related changes
Release note