-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDC Server support data-dir (#1879) #2069
CDC Server support data-dir (#1879) #2069
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@3AceShowHand seems there are conflicts need taking care of |
ea27660
to
c47682e
Compare
/run-all-tests |
/run-integration-tests |
/run-all-tests |
…ti-chi-bot/ticdc into cherry-pick-1879-to-release-4.0
/run-all-tests |
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2069 +/- ##
===================================================
- Coverage 53.7661% 52.6799% -1.0862%
===================================================
Files 153 165 +12
Lines 15958 17631 +1673
===================================================
+ Hits 8580 9288 +708
- Misses 6475 7365 +890
- Partials 903 978 +75 |
/run-all-tests |
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ec0c9de
|
/run-unit-tests |
This is an automated cherry-pick of #1879
What problem does this PR solve?
This PR makes TiCDC support
--data-dir
at the server level.What is changed and how it works?
--data-dir
is supported at the server level, default to""
, if not set, it will be set by conditions:/tmp/cdc_data
will be set as default data-dir--sort-dir
set, choose the valid one with the largest available space as data-dir.--sort-dir
set at both server level and changefeed level won't take effect, and default to/tmp/sorter
, this means it can not be changed by both command flag or config file/{data-dir}/tmp/sorter
Check List
Tests
Code changes
Side effects
Related changes
Release note