-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: fix changefeed update to properly handle sort-dir and start-ts #1921
Conversation
/run-integration-test |
/run-all-tests |
1 similar comment
/run-all-tests |
/run-all-tests |
/run-all-tests |
/run-all-tests |
1 similar comment
/run-all-tests |
…dc into zixiong-fix-changefeed-update
/run-all-tests |
/run-all-tests |
/run-all-tests |
1 similar comment
/run-all-tests |
run_cdc_cli changefeed update --sort-dir "/test" --no-confirm --changefeed-id $uuid 2>&1 | grep 'deprecated' | ||
if [[ $? != 0 ]]; then | ||
echo "[$(date)] <<<<< expected deprecation warning when trying to update sort-dir >>>>>" | ||
exit 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if it is updated successfully?
@asddongmen: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
What problem does this PR solve?
--sort-dir
--start-ts
What is changed and how it works?
Check List
Tests
Related changes
Release note
changefeed update
to properly handle--sort-dir
and--start-ts
.