Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix changefeed update to properly handle sort-dir and start-ts #1921

Closed
wants to merge 8 commits into from
Closed

cli: fix changefeed update to properly handle sort-dir and start-ts #1921

wants to merge 8 commits into from

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jun 3, 2021

What problem does this PR solve?

  • changefeed update does not support --sort-dir
  • changefeed update fails silently when the user tries to update --start-ts

What is changed and how it works?

  • fixed the two problems above

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Fix changefeed update to properly handle --sort-dir and --start-ts.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2021
@ti-chi-bot ti-chi-bot requested review from amyangfei and overvenus June 3, 2021 05:40
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Jun 3, 2021

/run-integration-test

@liuzix
Copy link
Contributor Author

liuzix commented Jun 3, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Jun 3, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jun 3, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jun 3, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jun 3, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Jun 4, 2021

/run-all-tests

@amyangfei amyangfei added this to the v5.1.0 milestone Jun 4, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Jun 4, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jun 4, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jun 4, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Jun 4, 2021

/run-all-tests

@liuzix liuzix marked this pull request as ready for review June 4, 2021 10:04
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2021
overvenus
overvenus reviewed Jun 4, 2021
View reviewed changes
tests/cli/run.sh
Comment on lines +134 to +138
run_cdc_cli changefeed update --sort-dir "/test" --no-confirm --changefeed-id $uuid 2>&1 | grep 'deprecated'
if [[ $? != 0 ]]; then
echo "[$(date)] <<<<< expected deprecation warning when trying to update sort-dir >>>>>"
exit 1
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if it is updated successfully？

@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jun 17, 2021
@amyangfei amyangfei added the release-blocker This issue blocks a release. Please solve it ASAP. label Jun 17, 2021
@ti-chi-bot
Copy link
Member

@asddongmen: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei amyangfei mentioned this pull request Jun 17, 2021
Closed
@amyangfei amyangfei removed the release-blocker This issue blocks a release. Please solve it ASAP. label Jun 18, 2021
@amyangfei amyangfei modified the milestones: v5.1.0, v5.1.1 Jun 21, 2021
@amyangfei amyangfei mentioned this pull request Jun 22, 2021
Closed
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@liuzix liuzix closed this Jul 14, 2021
This was referenced Jul 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus left review comments

@asddongmen asddongmen asddongmen approved these changes

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@liuzix @ti-chi-bot @amyangfei @overvenus @asddongmen