Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: port sink flow control for old processor & new processor to release-5.0 #1840

Merged
merged 11 commits into from
May 27, 2021
Merged

*: port sink flow control for old processor & new processor to release-5.0 #1840

merged 11 commits into from
May 27, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented May 26, 2021

What problem does this PR solve?

#1680

What is changed and how it works?

  1. sink flow control for old processor
  2. sink flow control for new processor

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Increased code complexity

Related changes

  • Need to update the documentation

Release note

  • Support sink flow control to reduce OOM

@ti-chi-bot ti-chi-bot requested review from amyangfei and zier-one May 26, 2021 06:44
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2021
@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2021

/run-all-tests

@liuzix liuzix added status/ptal Could you please take a look? component/replica-model Replication model component. labels May 26, 2021
@liuzix liuzix added this to the v5.0.2 milestone May 26, 2021
@overvenus
Copy link
Member

Does this PR port https://github.com/pingcap/ticdc/pull/1779 too?

@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2021

Does this PR port #1779 too?

No, because this PR is for release-5.0 only and #1779 is for master and release-5.0.
Currently, some processor related PRs are not testable on master, so I prioritized merging them into release branches.

@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2021

/run-all-tests

@amyangfei amyangfei added type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. release-blocker This issue blocks a release. Please solve it ASAP. labels May 26, 2021
@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2021

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@5740b2c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #1840   +/-   ##
================================================
  Coverage               ?   53.8315%           
================================================
  Files                  ?        154           
  Lines                  ?      16312           
  Branches               ?          0           
================================================
  Hits                   ?       8781           
  Misses                 ?       6610           
  Partials               ?        921

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2021
@overvenus
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 391ebae

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 27, 2021
@liuzix
Copy link
Contributor Author

liuzix commented May 27, 2021

/merge

@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei amyangfei mentioned this pull request May 27, 2021
Merged
@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 5069d1d into pingcap:release-5.0 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/replica-model Replication model component. release-blocker This issue blocks a release. Please solve it ASAP. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @overvenus @codecov-commenter @ti-chi-bot @amyangfei @lonng