-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv/client: use ephemeral goroutine to handle region range request (#1720) #1800
kv/client: use ephemeral goroutine to handle region range request (#1720) #1800
Conversation
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2c384d1
|
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1800 +/- ##
===================================================
- Coverage 53.7661% 52.5563% -1.2099%
===================================================
Files 153 153
Lines 15958 15941 -17
===================================================
- Hits 8580 8378 -202
- Misses 6475 6652 +177
- Partials 903 911 +8 |
/merge |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-tests |
This is an automated cherry-pick of #1720
What problem does this PR solve?
Fix part bug found in #1599
https://github.com/pingcap/ticdc/blob/109257825f7805bfc0f87b68d9ef7e969aa19161/cdc/kv/client.go#L578-L591
divideAndSendEventFeedToRegions
function scans range into several regions, and dispatch each region viascheduleRegionRequest
. There could be stale regions, and these stale regions will be resent tos.requestRangeCh
in L646. If thes.requestRangeCh
is full, deadlock happens.https://github.com/pingcap/ticdc/blob/109257825f7805bfc0f87b68d9ef7e969aa19161/cdc/kv/client.go#L627-L648
https://github.com/pingcap/ticdc/blob/109257825f7805bfc0f87b68d9ef7e969aa19161/cdc/kv/client.go#L616-L623
What is changed and how it works?
In order to consume region range request from
requestRangeCh
as soon as possible, we create a new goroutine to handle it. The sequence of region range we process is not matter, the region lock keeps the region access sequence. Besides the count or frequency of range request is limitted, we use ephemeral goroutine instead of permanent gourotine.Check List
Tests
Release note