-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: hide --sort-dir in changefeed command. (deprecated warning exists) (#1784) #1795
cmd: hide --sort-dir in changefeed command. (deprecated warning exists) (#1784) #1795
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: fefb29c
|
/merge |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #1784
What problem does this PR solve?
Hide
--sort-dir
in changefeed commandWhat is changed and how it works?
--sort-dir
in changefeed commandSortDir
to`json:"-"`
in changefeed, so thechangefeed query
won't print anysort-dir
which may confuse user. Note only set it to an ignore field is backward compatibilityCheck List
Tests
Release note