Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context: uniform the import naming of context, part 1 #1773

Merged
merged 1 commit into from
May 13, 2021
Merged

context: uniform the import naming of context, part 1 #1773

merged 1 commit into from
May 13, 2021

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

all context of std lib should be named as context
all context of cdc package should be named as cdcContext

this pr modified the code in ticdc/cdc/processor/pipeline package.

Check List

Tests

  • Unit test

Release note

  • No release note

@zier-one zier-one added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. labels May 13, 2021
@ti-chi-bot ti-chi-bot requested review from kennytm and lance6716 May 13, 2021 08:18
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2021
@ben1009
Copy link
Contributor

ben1009 commented May 13, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@ben1009: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

amyangfei
amyangfei reviewed May 13, 2021
View reviewed changes
cdc/processor/pipeline/sink.go
Comment on lines +56 to 64
// Load TableStatus with THREAD-SAFE
func (s *TableStatus) Load() TableStatus {
return TableStatus(atomic.LoadInt32((*int32)(s)))
}

func (s *TableStatus) store(new TableStatus) {
// Store TableStatus with THREAD-SAFE
func (s *TableStatus) Store(new TableStatus) {
atomic.StoreInt32((*int32)(s), int32(new))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Load and Store be used by other packages?

Copy link
Contributor Author

@zier-one zier-one May 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in the new owner, for test only

@amyangfei amyangfei added this to the v5.0.2 milestone May 13, 2021
@amyangfei amyangfei added the status/ptal Could you please take a look? label May 13, 2021
@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2021
@amyangfei
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2021
@zier-one
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1df82a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1773 (1df82a0) into master (86d4301) will decrease coverage by 1.1443%.
The diff coverage is 53.3707%.

@@               Coverage Diff                @@
##             master      #1773        +/-   ##
================================================
- Coverage   54.0130%   52.8686%   -1.1444%     
================================================
  Files           155        153         -2     
  Lines         16459      15896       -563     
================================================
- Hits           8890       8404       -486     
+ Misses         6630       6583        -47     
+ Partials        939        909        -30

@ti-chi-bot ti-chi-bot merged commit 58c6ca1 into pingcap:master May 13, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 13, 2021
@ti-chi-bot
This is an automated cherry-pick of pingcap#1773
a73a22d 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1774.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 13, 2021
@ti-chi-bot
This is an automated cherry-pick of pingcap#1773
38a2821 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1775.

zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 17, 2021
context: uniform the import naming of context, part 1 (pingcap#1773)
a8befdd
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
context: uniform the import naming of context, part 1 (pingcap#1773)
fbb0883
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
context: uniform the import naming of context, part 1 (pingcap#1773)
bf25d7e
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
context: uniform the import naming of context, part 1 (pingcap#1773)
9375b27
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
context: uniform the import naming of context, part 1 (pingcap#1773)
425393f
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
context: uniform the import naming of context, part 1 (pingcap#1773)
af231d3
ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
context: uniform the import naming of context, part 1 (#1773)
805b65d
ti-chi-bot pushed a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
context: uniform the import naming of context, part 1 (#1773)
688d3cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@kennytm kennytm Awaiting requested review from kennytm

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@zier-one @ben1009 @ti-chi-bot @lance6716 @amyangfei @codecov-commenter