Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: fix wrong usage in cdc server cli flag, --cert-allowed-cn #1697

Merged
merged 3 commits into from
Apr 27, 2021
Merged

cmd: fix wrong usage in cdc server cli flag, --cert-allowed-cn #1697

merged 3 commits into from
Apr 27, 2021

Conversation

ben1009
Copy link
Contributor

@ben1009 ben1009 commented Apr 26, 2021

What problem does this PR solve?

image

What is changed and how it works?

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Apr 26, 2021
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2021
@overvenus overvenus changed the title fix wrong usage in cdc server cli flag, --cert-allowed-cn cmd: fix wrong usage in cdc server cli flag, --cert-allowed-cn Apr 26, 2021
@overvenus
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. labels Apr 26, 2021
@amyangfei amyangfei added this to the v5.0.2 milestone Apr 26, 2021
@amyangfei
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 98e7197

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@3AceShowHand
Copy link
Contributor

/run-all-tests

1 similar comment
@3AceShowHand
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-leak-tests

@3AceShowHand
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #1697 (2690ea5) into master (4be4c1e) will increase coverage by 0.0219%.
The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master      #1697        +/-   ##
================================================
+ Coverage   53.8495%   53.8714%   +0.0219%     
================================================
  Files           153        153                
  Lines         16106      16105         -1     
================================================
+ Hits           8673       8676         +3     
  Misses         6523       6523                
+ Partials        910        906         -4

@ti-chi-bot ti-chi-bot merged commit 241e54d into master Apr 27, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 27, 2021
@ben1009 @ti-srebot
cherry pick pingcap#1697 to release-4.0
e0c26f0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1698

ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 27, 2021
@ben1009 @ti-srebot
cherry pick pingcap#1697 to release-5.0
e0138a4 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #1699

amyangfei pushed a commit that referenced this pull request Apr 28, 2021
@ti-srebot
cmd: fix wrong usage in cdc server cli flag, --cert-allowed-cn (#1697) …
a681738 
…#1698
ti-chi-bot pushed a commit that referenced this pull request May 13, 2021
@ti-srebot
cmd: fix wrong usage in cdc server cli flag, --cert-allowed-cn (#1697) (
e2a1c4b 
#1699)
@overvenus overvenus deleted the ticdc-fix-cdc-server-cli-usages branch June 23, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei Awaiting requested review from amyangfei

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
8 participants
@ben1009 @CLAassistant @overvenus @amyangfei @ti-chi-bot @3AceShowHand @codecov-commenter @ti-srebot