-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink/mysql: explicit_defaults_for_timestamp compatibility with mysql (#1638) #1658
sink/mysql: explicit_defaults_for_timestamp compatibility with mysql (#1638) #1658
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
/run-all-tests |
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d297e09
|
Codecov Report
@@ Coverage Diff @@
## release-4.0-pending #1658 +/- ##
========================================================
Coverage ? 50.8448%
========================================================
Files ? 152
Lines ? 15801
Branches ? 0
========================================================
Hits ? 8034
Misses ? 6930
Partials ? 837 |
cherry-pick #1638 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In ticdc repo: git pr https://github.com/pingcap/ticdc/pull/1658
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Fix #1585
What is changed and how it works?
explicit_defaults_for_timestamp
toON
in MySQL sink, which will keep the same behavior between upstream TiDB and downstream MySQL 5.7.explicit_defaults_for_timestamp
in downstream isOFF
, because in TiDB variableexplicit_defaults_for_timestamp
is readonly.Check List
Tests
Related changes
Release note
explicit_defaults_for_timestamp
toON
to make downstream MySQL5.7 keeps the same behavior with upstream TiDB.