Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix copyright check #1264

Merged
merged 1 commit into from
Jan 4, 2021
Merged

*: fix copyright check #1264

merged 1 commit into from
Jan 4, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jan 4, 2021

What problem does this PR solve?

  • The copyright checker should not rely on the current year.

What is changed and how it works?

  • Using regex to match copyright info.

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2021
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 4, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-5.0-rc labels Jan 4, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1264 (db6093a) into master (18aec01) will decrease coverage by 0.0460%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #1264        +/-   ##
================================================
- Coverage   46.2826%   46.2365%   -0.0461%     
================================================
  Files           129        129                
  Lines         13020      13020                
================================================
- Hits           6026       6020         -6     
- Misses         6332       6338         +6     
  Partials        662        662                

@ti-srebot ti-srebot merged commit a25a65a into master Jan 4, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Jan 4, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1265

ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Jan 4, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #1266

amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request Jan 5, 2021
ti-srebot added a commit that referenced this pull request Jan 5, 2021
ti-srebot added a commit that referenced this pull request Jan 5, 2021
amyangfei added a commit that referenced this pull request Jan 5, 2021
@zier-one zier-one deleted the liuzix-patch-1 branch February 3, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants