Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorter: Stabilize Unified Sorter (#1210) #1230

Merged
merged 5 commits into from
Jan 6, 2021
Merged

sorter: Stabilize Unified Sorter (#1210) #1230

merged 5 commits into from
Jan 6, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1210 to release-4.0

What problem does this PR solve?

  • Lack of mechanism to reduce the use of Goroutines in Unified Sorter.

What is changed and how it works?

  • WorkerPool is implemented to provide a mechanism in which one Goroutine can process events from multiple sources.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Enable Unified Sorter by default.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 24, 2020
Merged
@ti-srebot ti-srebot added component/puller Puller component. status/ptal Could you please take a look? type/4.0-cherry-pick labels Dec 24, 2020
@ti-srebot ti-srebot added this to the v4.0.10 milestone Dec 24, 2020
@liuzix
Copy link
Contributor

liuzix commented Dec 31, 2020

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1230 (2bc2ef3) into release-4.0 (6b7fb14) will decrease coverage by 1.4120%.
The diff coverage is 57.4610%.

@@                 Coverage Diff                 @@
##           release-4.0      #1230        +/-   ##
===================================================
- Coverage      45.9675%   44.5555%   -1.4120%     
===================================================
  Files              112        125        +13     
  Lines            11767      12802      +1035     
===================================================
+ Hits              5409       5704       +295     
- Misses            5747       6465       +718     
- Partials           611        633        +22

@liuzix
Copy link
Contributor

liuzix commented Dec 31, 2020

/run-all-tests

@liuzix
Copy link
Contributor

liuzix commented Jan 6, 2021

/run-all-tests

@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2021
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 2f9c29d into pingcap:release-4.0 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@liuzix liuzix

Labels
component/puller Puller component. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v4.0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @liuzix @codecov-io @overvenus @amyangfei