dm: fix chaos test #11686
Merged
dm: fix chaos test #11686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11686 +/- ##
================================================
+ Coverage 55.1577% 55.2627% +0.1049%
================================================
Files 1001 1001
Lines 136474 136640 +166
================================================
+ Hits 75276 75511 +235
+ Misses 55690 55626 -64
+ Partials 5508 5503 -5 |
|
/retest |
lance6716
approved these changes
Oct 28, 2024
| @@ -27,7 +27,7 @@ var ( | |||
| // NOTE: items in `doSchemas` should be specified in the corresponding task files (`filenames`). | |||
| // TODO: can not support optimistic shard DDL now because go-sqlsmith will generated some statements like | |||
| // `ALTER TABLE `db_optimistic`.`dxeyydwb` ADD COLUMN (`zuhxfgsce` INT(18) NOT NULL)` which has NOT NULL column without DEFAULT value. | |||
| filenames = []string{"task-single.yaml", "task-pessimistic.yaml", "task-optimistic.yaml"} | |||
| filenames = []string{"task-single.yaml"} | |||
There was a problem hiding this comment.
pass it by command line argument?
There was a problem hiding this comment.
Yes, will update it in next pr
ti-chi-bot
bot
added
needs-1-more-lgtm
D3Hunter
approved these changes
Oct 29, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4287
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note