Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot (ticdc): reduce list tables time consumption (#11095) #11126

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11095

What problem does this PR solve?

Issue Number: close #11124

ref #11109

What is changed and how it works?

  1. Use [ListSimpleTables](pingcap/tidb@master/pkg/meta/meta.go#L1026) to retrieve TableNameInfo. This only includes the name and ID of a table, making it smaller than TableInfo.
  2. Apply a filter to the retrieved TableNameInfos to locate the tables of interest.
  3. Use [GetTable](pingcap/tidb@master/pkg/meta/meta.go#L1219) to acquire the schema of the selected tables.

This approach can reduce time costs by minimizing the amount of data that needs to be loaded.

Check List

Tests

  • Unit test
    Covered by existed unit tests.
  • Manual test (add detailed scripts or steps below)

Test Environment

1 TiDB cluster(4000 tables in database test), 1 TiCDC.

Test Result

Create 100 changefeeds using the configuration provided below:

[filter]
rules = ['test.*100*','test.*101*','test.*102*','test.*103*']

Each changefeed will replicate 56 tables.

Before this PR, when the CDC server was restarted, the lag for changefeeds increased to approximately 1.5 minutes.

It took around 2.5 seconds to initialize the schema snapshot for each changefeed, as shown in the log below:

[2024/05/14 18:25:55.952 +08:00] [INFO] [snapshot.go:219] ["schema snapshot created"] [changefeed=default/test-74] [currentTs=449755804227862532] [cost=2.523837041]

After implementing this PR, the lag for changefeeds increased to about 50 seconds when the CDC server was restarted.

It now takes approximately 1.4 seconds to initialize the schema snapshot for each changefeed. The log for this will be shown below.

[2024/05/14 18:20:53.578 +08:00] [INFO] [snapshot.go:233] ["schema snapshot created"] [changefeed=default/test-15] [currentTs=449755753175580674] [cost=1.418892458]

However, if the changefeed aims to replicate all 4000 tables in db, this PR might be slightly slower by 0.5s compared to the version without this PR, as it needs to load the raw table schemas twice. This issue can be addressed by solution 2, as elaborated in #11109, which I will implement later.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Reduce the time consumption of changefeed initialization. 

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-8.1@f98b245). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.7417% <0.0000%> (?)
dm 51.2627% <0.0000%> (?)
engine 63.4232% <0.0000%> (?)
Flag Coverage Δ
unit 57.4580% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11126   +/-   ##
================================================
  Coverage               ?   57.4580%           
================================================
  Files                  ?        852           
  Lines                  ?     125784           
  Branches               ?          0           
================================================
  Hits                   ?      72273           
  Misses                 ?      48084           
  Partials               ?       5427           

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 20, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 137ed65 into pingcap:release-8.1 May 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants