Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdClient (ticdc): Enable the pdClient forwarding function to make cdc more stable during network isolation between the PD leader (#11076) #11086

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11076

What problem does this PR solve?

Issue Number: close #10849

What is changed and how it works?

Enable pdClient's forwarding function, make it can forward request to PD follower if cdc is network isolated with PD Leader.

Enabling forwarding will introduce additional network round trips between the PD follower and PD leader. However, since TiCDC doesn't call the PD API frequently, it won't affect TiCDC's performance.

So we decide to enable it by default.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

This PR has been tested multiple times in the HA case [ha-ticdc-non-owner-random-to-pdleader-network-partition-last-for-10m]. The results indicate that it functions as expected:
image

The changefeed's lag is not affected by the network partition between CDC and the PD leader anymore.
image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Enable the pdClient forwarding function to make cdc more stable during network isolation between the PD leader.

… more stable during network isolation between the PD leader (pingcap#11076)

close pingcap#10849
@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 13, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. labels May 13, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@3a95436). Click here to learn what that means.

Additional details and impacted files
Components Coverage Δ
cdc 61.7544% <0.0000%> (?)
dm 51.2608% <0.0000%> (?)
engine 63.4161% <0.0000%> (?)
Flag Coverage Δ
unit 57.4588% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11086   +/-   ##
================================================
  Coverage               ?   57.4588%           
================================================
  Files                  ?        852           
  Lines                  ?     125657           
  Branches               ?          0           
================================================
  Hits                   ?      72201           
  Misses                 ?      48042           
  Partials               ?       5414           

Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 14, 2024
@asddongmen asddongmen removed the affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. label May 14, 2024
@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 862a9aa into pingcap:release-8.1 May 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants