pdClient (ticdc): Enable the pdClient forwarding function to make cdc more stable during network isolation between the PD leader (#11076) #11084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
lgtm
release-note
ti-chi-bot
added
the
type/cherry-pick-for-release-7.5
ti-chi-bot
added
the
cherry-pick-approved
Signed-off-by: dongmen <[email protected]>
asddongmen
approved these changes
May 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #11076
What problem does this PR solve?
Issue Number: close #10849
What is changed and how it works?
Enable pdClient's forwarding function, make it can forward request to PD follower if cdc is network isolated with PD Leader.
Enabling forwarding will introduce additional network round trips between the PD follower and PD leader. However, since TiCDC doesn't call the PD API frequently, it won't affect TiCDC's performance.
So we decide to enable it by default.
Check List
Tests
This PR has been tested multiple times in the HA case [ha-ticdc-non-owner-random-to-pdleader-network-partition-last-for-10m]. The results indicate that it functions as expected:
The changefeed's lag is not affected by the network partition between CDC and the PD leader anymore.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note