Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: upgrade go-mysql library #11043

Merged
merged 1 commit into from
May 7, 2024
Merged

dm: upgrade go-mysql library #11043

merged 1 commit into from
May 7, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented May 7, 2024

What problem does this PR solve?

Issue Number: close #11041

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

upgrade go-mysql to fix the connection blocked when read handshake packet

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
@D3Hunter
Copy link
Contributor Author

D3Hunter commented May 7, 2024

@lance6716

@D3Hunter
Copy link
Contributor Author

D3Hunter commented May 7, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.4109%. Comparing base (894b36f) to head (b4bd8f1).
Report is 138 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.6878% <ø> (+0.0231%) ⬆️
dm 51.2477% <ø> (+0.0101%) ⬆️
engine 63.3808% <ø> (-0.0071%) ⬇️
Flag Coverage Δ
unit 57.4109% <ø> (+0.0143%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11043        +/-   ##
================================================
+ Coverage   57.3966%   57.4109%   +0.0143%     
================================================
  Files           851        851                
  Lines        125469     125469                
================================================
+ Hits          72015      72033        +18     
+ Misses        48034      48023        -11     
+ Partials       5420       5413         -7     

Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 7, 2024
Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 08:30:00.06481106 +0000 UTC m=+950753.821946628: ☑️ agreed by lance6716.
  • 2024-05-07 09:43:53.047327455 +0000 UTC m=+955186.804463028: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 566c77c into master May 7, 2024
28 checks passed
@ti-chi-bot ti-chi-bot bot deleted the upgrade-go-mysql branch May 7, 2024 10:31
@D3Hunter D3Hunter added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 28, 2024
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels May 28, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11187.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 28, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11188.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11189.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 28, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 28, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jun 13, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jul 30, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 28, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 28, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11700.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binlogsyncer readInitialHandshake blocks for 10 more hours
4 participants