Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: Add incremental scan long time region count metrics #10864

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

hongyunyan
Copy link
Collaborator

@hongyunyan hongyunyan commented Mar 29, 2024

What problem does this PR solve?

Issue Number: ref #10862

What is changed and how it works?

Add incremental scan long time region count metrics.
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #10864 (a913394) into master (db60e9e) will decrease coverage by 0.0113%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
Components Coverage Δ
cdc 61.9308% <ø> (+0.0533%) ⬆️
dm 51.2899% <ø> (+0.0404%) ⬆️
engine 63.4373% <ø> (+0.0423%) ⬆️
Flag Coverage Δ
unit 57.5446% <ø> (-0.0113%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10864        +/-   ##
================================================
- Coverage   57.5558%   57.5446%   -0.0113%     
================================================
  Files           853        850         -3     
  Lines        126974     125301      -1673     
================================================
- Hits          73081      72104       -977     
+ Misses        48454      47816       -638     
+ Partials       5439       5381        -58     

@hongyunyan hongyunyan changed the title [WIP]ticdc: Add incremental scan long time region count metrics ticdc: Add incremental scan long time region count metrics Mar 29, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 29, 2024
@asddongmen asddongmen added the area/ticdc Issues or PRs related to TiCDC. label Apr 3, 2024
@asddongmen
Copy link
Contributor

Please clarify the definition of "long time" within the metric's description.

metrics/grafana/ticdc.json Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-03 05:56:24.568833151 +0000 UTC m=+423446.096373689: ☑️ agreed by asddongmen.
  • 2024-04-03 06:18:16.695603299 +0000 UTC m=+424758.223143844: ☑️ agreed by lidezhu.

@hongyunyan
Copy link
Collaborator Author

/retest

1 similar comment
@hongyunyan
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit d4a68fd into pingcap:master Apr 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ticdc Issues or PRs related to TiCDC. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants