Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: Add metrics to observe slow initialize region count #10863

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

hongyunyan
Copy link
Collaborator

@hongyunyan hongyunyan commented Mar 29, 2024

What problem does this PR solve?

Issue Number: ref #10862

What is changed and how it works?

Add metrics to observe slow initialize region count
image

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 29, 2024
@CharlesCheung96
Copy link
Contributor

Please add an example of the new monitoring.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #10863 (10f0a0b) into master (db389b1) will increase coverage by 0.1413%.
Report is 1 commits behind head on master.
The diff coverage is 42.8571%.

Additional details and impacted files
Components Coverage Δ
cdc 62.1282% <42.8571%> (+0.2525%) ⬆️
dm 51.2495% <ø> (+0.0161%) ⬆️
engine 63.4373% <ø> (+0.0564%) ⬆️
Flag Coverage Δ
unit 57.6872% <42.8571%> (+0.1413%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10863        +/-   ##
================================================
+ Coverage   57.5458%   57.6872%   +0.1413%     
================================================
  Files           853        853                
  Lines        126937     127094       +157     
================================================
+ Hits          73047      73317       +270     
+ Misses        48449      48351        -98     
+ Partials       5441       5426        -15     

Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-29 03:29:34.859253913 +0000 UTC m=+2211401.881500301: ☑️ agreed by CharlesCheung96.
  • 2024-03-29 05:59:23.54550215 +0000 UTC m=+2220390.567748538: ☑️ agreed by 3AceShowHand.

@hongyunyan
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit db60e9e into pingcap:master Mar 29, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants